PathGroupLoader portability on Windows and multiple drives

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
52/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
java
Domain
operating-systems

Research direction

Open org.antlr.stringtemplate.PathGroupLoader.java and inspect line 36, where paths are tokenized using a colon. Reproduce the lookup with the application on one Windows drive and launched from another, then verify that drive-letter paths resolve correctly using the platform path separator.

Written by the indexing model from the issue text.

Description

Hello,

Class org.antlr.stringtemplate.PathGroupLoader.java has an issue concerning Windows-specific applications, when the program using StringTemplates is located on a hard drive (e.g. "C:") and you run the program from another drive (e.g. "D:"), having it in your path.

Error message in that case:
"String template error: no such group file " (+ file name)

At line 36, tokenization is done thanks to the ":" separator which is wrong with Windows (think about "C:"...).

Suggestion: use File.pathSeparator instead and the problem is solved. An other solution for users is to override the constructor and do this instead.

Best regards !

Dominant language
Java
Stars
15
Forks
11
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.