ant-design/ant-design

Popover remains visible when component tree is suspended

Open

#38,158 opened on Oct 21, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (98,031 stars) (54,612 forks)batch import
Inactivehelp wanted

Description

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Open Popover by clicking on the Open Popover button
  2. Trigger suspense by clicking on the popover content button Hide and load data
  3. See popover remaining visible while the component tree is suspended.

What is expected?

The popover to be hidden.

What is actually happening?

The popover remains visible.

Environment Info
antd 4.23.6
React 17
System Linux
Browser Google Chrome

React.Suspense provide a lifecycle so components can handle the display:none removal. This can be used to handle this: https://github.com/facebook/react/issues/14536

Contributor guide

Tech stack
typescriptreactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactReact Suspenseantd Popover component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Examine the antd Popover component code (likely in components/popover) to find where visibility is toggled. Check the React Suspense lifecycle hooks as referenced in the linked React issue (https://github.com/facebook/react/issues/14536). The fix may involve listening to the onMount or onError callbacks from Suspense to hide the popover. No pull requests are linked; the issue is open and unassigned.