ant-design/ant-design

Add back expandIconAsCell={false} in > 4.0

Open

#26,021 opened on Aug 5, 2020

View on GitHub
 (4 comments) (3 reactions) (0 assignees)TypeScript (98,031 stars) (54,612 forks)batch import
Inactivehelp wanted

Description

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

It used to be possible to set expandIconAsCell={false} and have the expand Icon show up in the same cell as other data. This was a much more compressed layout and better when you also are using the table select or have some rows that cannot be expanded.

Maybe it's possible to achieve this via different API, but it's not documented and is a breaking change when upgrading from 3.x

What does the proposed API look like?

Add back expandIconAsCell. Same API as before

Example

3.x

4.x

Contributor guide

Tech stack
reacttypescript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptAnt Design Table component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the current Table component source code in 'components/table' to understand how `expandIconAsCell` was removed and if an alternative exists. Review the issue discussion for any maintainer feedback (only 4 comments). Check if the feature was already implemented or deprecated in favor of a different API. Since no PR is linked, a new implementation would require adding the prop back with backward compatibility consideration.