ant-design/ant-design-mobile

src/components/swiper/swiper.tsx 第362行 width: `${startIndex * 100}%`, 在垂直的情况下应该改为 height: `${startIndex * 100}%`

Open

#6567 opened on Mar 7, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (11,238 stars) (2,313 forks)batch import
bughelp wanted

Description

Version of antd-mobile

v5.34.0

Operating system and its version

No response

Browser and its version

No response

Sandbox to reproduce

No response

What happened?

src/components/swiper/swiper.tsx 第362行 width: ${startIndex * 100}%, 在direction='vertical'的情况下应该改为 height: ${startIndex * 100}%

Relevant log output

No response

Contributor guide

Tech stack
typescriptreact
Domain
frontendmobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSBasic React component knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue is in src/components/swiper/swiper.tsx at line 362. The current code sets width based on startIndex, but when direction is 'vertical', it should set height instead. The fix is straightforward: change the CSS property depending on the direction prop. No additional dependencies or complex logic needed.