ansible/awx

Allow to add a new choice for a existing variable in custom credential type after it is already in use

Open

#8792 opened on Dec 9, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (13,071 stars) (3,333 forks)batch import
component:apihelp wantedtype:enhancement

Description

ISSUE TYPE
  • Feature Idea
SUMMARY

I made a form with choices in a custom credential type, this custom credential type is in use in a credential. if I modify a var name in the INJECTOR, it's fine, but if I want to add a choice for a var already existing I get an error message :

Modifications to inputs are not allowed for credential types that are in use

I could understand if I was trying to modify the field name, as the form is not the same that the one in use, but just adding a choice doesn't modify the fields or the number of fields, nothing really important in fact, but it is blocked

We can't delete all the credential using a credential type, if we just need to add a choice

Contributor guide

Tech stack
pythondjangorest api
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of AWX credential typesFamiliarity with Django models
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is about a validation in the credential type model. Look at the model or serializer for CredentialType, specifically the logic that prevents modification of inputs when the credential type is in use. The current code likely compares the new inputs with old ones and rejects changes. To allow adding choices, you would need to modify the validation to permit additive changes to choices fields while still blocking other modifications. Check the file awx/api/serializers.py or awx/main/models/credential.py for the relevant validation.