ansible/awx

Remove some of the eslint-disable comments

Open

#11,707 opened on Feb 9, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (3,333 forks)batch import
Hacktoberfestcomponent:uigood first issuetype:enhancementtype:task

Repository metrics

Stars
 (13,071 stars)
PR merge metrics
 (Avg merge 24d 6h) (30 merged PRs in 30d)

Description

ISSUE TYPE
  • Feature Idea
SUMMARY

There are several places in the code basis that we use - eslint-disable and certain rule, we need to verify which ones we should keep in place, and make changes accordingly.

This PR https://github.com/ansible/awx/pull/11568 added a couple more in order to speed up the react-scripts bump process.

Contributor guide

Research direction
Inspect each eslint disable comment in the codebase, verify if the rule violation is still present, and remove the disable comment if the violation has been fixed or the rule is no longer needed.
Tech stack
javascriptreact
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScripteslint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75