ansible/awx

Remove some of the eslint-disable comments

Open

#11707 opened on Feb 9, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (13,071 stars) (3,333 forks)batch import
Hacktoberfestcomponent:uigood first issuetype:enhancementtype:task

Description

ISSUE TYPE
  • Feature Idea
SUMMARY

There are several places in the code basis that we use - eslint-disable and certain rule, we need to verify which ones we should keep in place, and make changes accordingly.

This PR https://github.com/ansible/awx/pull/11568 added a couple more in order to speed up the react-scripts bump process.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ESLint knowledgeReact basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the codebase for eslint disable comments, focusing on those added in PR #11568. Review each comment to determine if the disabled rule is still necessary, and remove or keep accordingly. Ensure that after removal, the linting passes without errors. Check the existing comments in the issue for additional context.