anlutro/php-curl

Implement interface?

Open

#42 opened on Apr 27, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)PHP (48 forks)github user discovery
code qualityenhancementhelp wanted

Repository metrics

Stars
 (244 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It would be wonderful if you could have your cURL class implement some interface.

Right now, if I want to type-hint the type of a class method argument, I'm forced to type hint the concrete class. If the concrete class would implement an interface, I could type-hint the interface instead. If I can type-hint an interface, I can more easily supply a mock object for unit testing purposes.

Contributor guide

Research direction
Create an interface (e.g., CurlInterface) with the public methods of the cURL class, then make the cURL class implement that interface. Update any type hints in the codebase to use the interface.
Tech stack
php
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85