anlutro/laravel-4-smart-errors

Treat MethodNotAllowedHttpException the same as NotFoundHttpException?

Open

#31 opened on Nov 7, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)PHP (13 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (65 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've noticed that MethodNotAllowedHttpExceptions are usually not caused by bugs in the code, but are harmless user errors. (Or more often, triggered by spam or indexing bots.)

The README says:

404 errors are written in the log as warnings with the URL accessed + referrer [and no notification emails are sent]

I think it could be useful to do the same for wrong-method errors.

I also saw this:

If you want to handle specific types of exceptions yourself, you can add App::error closures with those specific exceptions as arguments. Exceptions handled using App::error will not be e-mailed or logged by this package.

and I can do that instead, but I though this might be something the package could handle.

Thoughts? If you'd like to do this, I can probably send another PR.

Contributor guide

Research direction
Examine how NotFoundHttpException is logged and suppressed in the package, then implement similar handling for MethodNotAllowedHttpException.
Tech stack
php
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Laravel basic knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75