ankidroid/Anki-Android

FLAG_FULLSCREEN deprecation in API 30

Closed

#9,332 opened on Jul 29, 2021

View on GitHubContributor guide
 (13 comments) (0 reactions) (1 assignee)Kotlin (2,789 forks)batch import
DeprecationHelp WantedKeep OpenResearch

Repository metrics

Stars
 (11,132 stars)
PR merge metrics
 (Avg merge 9d 12h) (93 merged PRs in 30d)

Description

[!IMPORTANT] This issue is to be included in a research study, and should not be worked on

  • FLAG_FULLSCREEN
    • Use WindowInsetsController.hide(int) with WindowInsets.Type.statusBars() instead.
    • Only the usage in AnkiActivity needs to be fixed. The usage in Reviewer.kt doesn't need to be fixed because the screen is deprecated

The deprecations below don't need to be fixed because the screen that uses it is deprecated and will be eventually removed.

  • View.setOnSystemUiVisibilityChangeListener
    • Use WindowInsets.isVisible(int) to find out about system bar visibilities by setting a View.OnApplyWindowInsetsListener on this view
  • View.getSystemUiVisibility()
    • SystemUiVisibility flags are deprecated. Use WindowInsetsController instead.

Contributor guide

Research direction
The fix involves replacing FLAG FULLSCREEN with WindowInsetsController.hide() in the AnkiActivity file. Refer to the issue description for details on which parts to modify. Note that the issue is part of a research study and should not be worked on.
Tech stack
kotlinandroid
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Kotlin basicsAndroid API 30
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40