ankidroid/Anki-Android

Reviewer - OnRenderProcessGone Crash - You cannot show a dialog before an Activity is created or after it's hidden

Open

#6,244 opened on May 22, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Kotlin (2,789 forks)batch import
2.10.x2.9.xBugHelp WantedKeep OpenPriority-Medium

Repository metrics

Stars
 (11,132 stars)
PR merge metrics
 (Avg merge 9d 12h) (93 merged PRs in 30d)

Description

https://couchdb.ankidroid.org/acralyzer/_design/acralyzer/index.html#/report-details/896af9d5-cb72-4c8e-8ba1-6e3e0f233819

com.afollestad.materialdialogs.MaterialDialog$DialogException: Bad window token, you cannot show a dialog before an Activity is created or after it's hidden.
at com.afollestad.materialdialogs.MaterialDialog.show(MaterialDialog.java:2)
at com.afollestad.materialdialogs.MaterialDialog$Builder.show(MaterialDialog.java:2)
at com.ichi2.anki.AbstractFlashcardViewer$CardViewerWebClient.displayRenderLoopDialog(AbstractFlashcardViewer.java:13)
at com.ichi2.anki.AbstractFlashcardViewer$CardViewerWebClient.onRenderProcessGone(AbstractFlashcardViewer.java:24)
at gk.a(PG:1)
at org.chromium.android_webview.AwContents.onRenderProcessGone(PG:9)
at android.os.MessageQueue.nativePollOnce(Native Method)
at android.os.MessageQueue.next(MessageQueue.java:326)
at android.os.Looper.loop(Looper.java:160)
at android.app.ActivityThread.main(ActivityThread.java:6898)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:537)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Contributor guide

Research direction
Investigate the onRenderProcessGone callback in AbstractFlashcardViewer.CardViewerWebClient. Ensure that displayRenderLoopDialog only attempts to show a dialog when the Activity is in a valid state (e.g., not finishing, not destroyed). Consider using isFinishing() or check for Activity destruction before showing the dialog.
Tech stack
kotlin
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentKotlinActivity lifecycleWebView
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40