ankidroid/Anki-Android

DialogHandler assumes it was started by DeckPicker, may crash otherwise

Open

#5,075 opened on Oct 21, 2018

View on GitHub
 (18 comments) (0 reactions) (1 assignee)Kotlin (11,132 stars) (2,789 forks)batch import
2.8.x2.9.xBugHelp WantedKeep OpenPriority-HighRelease process

Description

Reproduction Steps
  1. Open AnkiDroid via a Reviewer-first pathway?
  2. request file import?
Expected Result

Import dialog is shown

Actual Result

ClassCastException because import dialog is spawned from Reviewer somehow, instead of DeckPicker?

java.lang.ClassCastException: com.ichi2.anki.Reviewer cannot be cast to com.ichi2.anki.DeckPicker
at com.ichi2.anki.dialogs.DialogHandler.handleMessage(DialogHandler.java:82)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6501)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Contributor guide

Tech stack
kotlinandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android development basicsUnderstanding of AnkiDroid's DeckPicker and Reviewer
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate DialogHandler.handleMessage() in DialogHandler.java. The crash occurs because it assumes the activity is DeckPicker. Consider checking if the activity is an instance of DeckPicker or Reviewer, or redesign the dialog creation to be context independent. Review the call chain from imports to understand how DialogHandler is invoked from Reviewer. Look at issue comments for any suggested fixes.