angulardart/angular

Sanity check directives|pipes|providers for validitity

Open

#539 opened on Jul 19, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Dart (1,855 stars) (237 forks)batch import
area: compilergood first issue⛈ experience: new user⛑ breaking change

Description

@Component(selector: 'test-component',
                   directives: const [NgIf, NgFor],
                   template: 'It works!')
class TestComponent {
...

produces the following HTML:

<test-component>It works!</test-component>

If for some reason you were not really awake and write this:

@Component(selector: 'test-component',
                   directives: const [NgIf, NgFor, DatePipe],
                   template: 'It works!')
class TestComponent {
...

you end up with the follow HTML:

<test-component></test-component>

No visible error in pub serve nor in the dartium console. A .template.dart file for the faulty component is generated but the content is the same as if you omit the template property in Component annotation.

I didn't tested this with Angular 4 alpha

Contributor guide

Tech stack
dartangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
DartAngularDartComponent annotations
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the AngularDart compiler's handling of directives and pipes in the @Component annotation. Focus on the compiler's validation phase, likely in the template compiler, where it should check that only valid directive types are listed. The fix should ensure that invalid types like DatePipe are caught and an error is reported instead of silently failing.