angular/components

Overlay is not destroyed while navigating using Browser's Back/Forward button (RouteReuseStrategy is used)

Closed

#17,973 opened on Dec 16, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (6,650 forks)batch import
P3area: cdk/overlayhelp wanted

Repository metrics

Stars
 (24,044 stars)
PR merge metrics
 (Avg merge 2d 16h) (80 merged PRs in 30d)

Description

Reproduction

https://angular-hlrhkp-pzxidw.stackblitz.io/

Steps to reproduce:

  1. Click on the navigate to second page link.
  2. Click on Browser Back Button and Open the select box .
  3. Click on the browser forward button to navigate.

Expected Behavior

What behavior were you expecting to see? The overlay of the previous component should be destroyed, when the browser navigation buttons clicked

Actual Behavior

What behavior did you actually see? The overlay of the material persists even after the page is routed to next page

Environment

  • Angular:
  • CDK/Material: 5.21
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows

Contributor guide

Research direction
Investigate how Angular CDK overlay's lifecycle interacts with router navigation when RouteReuseStrategy is used. Look at the overlay ref counting mechanism in the OverlayRef and how it handles detach on route change. Check if there is a missing cleanup when the route is reused. Consider examining the following files: overlay ref.ts, overlay container.ts, and the RouterModule setup.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Angular basicsAngular CDK OverlayRouteReuseStrategy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25