`ng add @angular/fire` stops with `Cannot read properties of undefined (reading 'email')` on firebase-tools 15
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- angular, firebase, typescript
- Domain
- cli
Research direction
Start with src/schematics/setup/prompts.ts:110 and src/schematics/setup/index.ts:95, then inspect src/schematics/firebaseTools.ts:30 and reproduce with firebase-tools 15. Add coverage for the version 15 login shape and ensure setup proceeds through the account, project and app questions without writing errors.
Written by the indexing model from the issue text.
Description
ng add @angular/fire fails for anyone whose Firebase CLI is version 15, which is what npm installs today.
Reproduction
In an Angular 21 application with firebase-tools 15.28.1 resolvable, run ng add @angular/fire@next and pick any feature. Setup prints:
Using firebase-tools version 15.28.1
Cannot read properties of undefined (reading 'email')
It stops there, before the account, project and app questions, so nothing is written to the workspace.
Cause
userPrompt in src/schematics/setup/prompts.ts:110 reads defaultUser.email, where defaultUser comes from await firebaseTools.login(options).
- Called inside a terminal, that call returns an object carrying
emailon firebase-tools 14.27.0 and returnsundefinedon 15.28.1, so the read throws. src/schematics/setup/index.ts:95readsuser.emailfrom the same source and has the same exposure.
Who hits it
Everyone with firebase-tools 15 installed, and everyone with no Firebase CLI at all:
src/schematics/firebaseTools.ts:30installs the newest version (npm i --location=global firebase-tools), which is 15.30.2 today.- The declared range accepts it (
firebase-tools: ^14.0.0 || ^15.0.0, widened in #3701). - Installing firebase-tools 14 makes the whole flow complete.
Directions for a fix
Read the account from login.list() rather than from login(), or treat an undefined return as "no default account" instead of reading a property from it. A spec covering the version 15 shape would be worth adding, since nothing exercises this path today.
- Dominant language
- TypeScript
- Stars
- 7.8k
- Forks
- 2.2k
- Avg merge
- 3d 6h
- Merged PRs (30d)
- 5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from angular/angularfire
-
comp: build/pipeline type: bug version: current (v17+)
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
angular/angularfire#3766 ·
-
comp: docs type: chore version: current (v17+)
Difficulty 4/5 3-5 days Newbie friendliness 58/100
angular/angularfire#3764 ·
-
comp: firestore comp: ssr priority: P0 (critical) type: feature version: current (v17+)
angular/angularfire#3757 · 1 assignee ·
-
Six `firebase` entry points have no `@angular/fire` equivalent, so their exports are unreachable Opencomp: core type: feature
angular/angularfire#3755 · 1 assignee ·
-
comp: auth comp: ssr comp: zones type: bug
Difficulty 3/5 1-2 days Newbie friendliness 76/100
angular/angularfire#3748 ·
All issues in angular/angularfire
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
safetrustcr/dApp-SafeTrust#426 ·
-
area:workflow bug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
fil-donadoni/tolaria#4409 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Fission-AI/OpenSpec#1960 ·
-
Add dependabot Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
corsairdev/corsair#1764 ·