ng new my-project --skip-tests shouldn't generate karma/protractor files

Open
#9,160 30 comments 50 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
angular, typescript
Domain
cli, testing

Research direction

Start by running ng new my-project --skip-tests and compare the generated files with the observed and desired lists in the issue. Trace the ng new entry point and its handling of --skip-tests, then verify that the test.ts, tsconfig.spec.json, e2e, karma.conf.js, and protractor.conf.js files are omitted while the remaining files are generated.

Written by the indexing model from the issue text.

Description

area: @schematics/angular freq2: medium severity2: inconvenient type: bug/fix

The --skip-tests flag for ng new didn't quite match my expectations as a developer.

Versions
Angular CLI: 1.6.0-beta.0
Node: 8.4.0
OS: linux x64
Angular: 
...
Repro steps

ng new my-project --skip-tests

Observed behavior
  create my-project/.angular-cli.json (1528 bytes)
  create my-project/.editorconfig (245 bytes)
  create my-project/.gitignore (516 bytes)
  create my-project/src/assets/.gitkeep (0 bytes)
  create my-project/src/environments/environment.prod.ts (51 bytes)
  create my-project/src/environments/environment.ts (387 bytes)
  create my-project/src/favicon.ico (5430 bytes)
  create my-project/src/index.html (296 bytes)
  create my-project/src/main.ts (370 bytes)
  create my-project/src/polyfills.ts (2667 bytes)
  create my-project/src/styles.css (80 bytes)
  create my-project/src/test.ts (1085 bytes)
  create my-project/src/tsconfig.app.json (211 bytes)
  create my-project/src/tsconfig.spec.json (304 bytes)
  create my-project/src/typings.d.ts (104 bytes)
  create my-project/e2e/app.e2e-spec.ts (292 bytes)
  create my-project/e2e/app.po.ts (208 bytes)
  create my-project/e2e/tsconfig.e2e.json (235 bytes)
  create my-project/karma.conf.js (923 bytes)
  create my-project/package.json (1322 bytes)
  create my-project/protractor.conf.js (722 bytes)
  create my-project/tsconfig.json (363 bytes)
  create my-project/tslint.json (2985 bytes)
  create my-project/src/app/app.module.ts (316 bytes)
  create my-project/src/app/app.component.css (0 bytes)
  create my-project/src/app/app.component.html (1120 bytes)
  create my-project/src/app/app.component.ts (207 bytes)
Desired behavior
  create my-project/.angular-cli.json (1528 bytes)
  create my-project/.editorconfig (245 bytes)
  create my-project/.gitignore (516 bytes)
  create my-project/src/assets/.gitkeep (0 bytes)
  create my-project/src/environments/environment.prod.ts (51 bytes)
  create my-project/src/environments/environment.ts (387 bytes)
  create my-project/src/favicon.ico (5430 bytes)
  create my-project/src/index.html (296 bytes)
  create my-project/src/main.ts (370 bytes)
  create my-project/src/polyfills.ts (2667 bytes)
  create my-project/src/styles.css (80 bytes)
  create my-project/src/tsconfig.app.json (211 bytes)
  create my-project/src/typings.d.ts (104 bytes)
  create my-project/package.json (1322 bytes)
  create my-project/tsconfig.json (363 bytes)
  create my-project/tslint.json (2985 bytes)
  create my-project/src/app/app.module.ts (316 bytes)
  create my-project/src/app/app.component.css (0 bytes)
  create my-project/src/app/app.component.html (1120 bytes)
  create my-project/src/app/app.component.ts (207 bytes)
Dominant language
TypeScript
Stars
27k
Forks
11.8k
Avg merge
16h 35m
Merged PRs (30d)
176

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from angular/angular-cli

All issues in angular/angular-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.