filter does not work in UnitTestTree

Open
#26,000 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
angular, typescript
Domain
cli, testing, tooling

Research direction

Start with the linked angular-schematics-filter reproduction and run its hello-world schematics test. Trace how filter() handles UnitTestTree and compare that path with the reported unsupported-tree error. Done means the filter operation works on UnitTestTree and the reproduction test passes.

Written by the indexing model from the issue text.

Description

area: @angular-devkit/schematics freq1: low severity3: broken type: bug/fix
Command

generate

Is this a regression?
  • Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was

No response

Description

filter() does not work when applied to a UnitTestTree

I believe this is because UnitTestTree is not a HostTree

Minimal Reproduction

https://github.com/cheng93/angular-schematics-filter

run the test in the hello-world schematics

Exception or Error
Error: Tree type is not supported.
Your Environment
_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 16.1.8
Node: 20.0.0 (Unsupported)
Package Manager: npm 9.6.4
OS: win32 x64

Angular: 16.2.8
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1601.8
@angular-devkit/core         16.1.8
@angular-devkit/schematics   16.1.8
@angular/cli                 16.1.8
@schematics/angular          16.1.8
rxjs                         7.8.1
typescript                   5.1.6
zone.js                      0.13.3
Anything else relevant?

No response

Dominant language
TypeScript
Stars
27k
Forks
11.8k
Avg merge
16h 35m
Merged PRs (30d)
176

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from angular/angular-cli

All issues in angular/angular-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.