Angular builders - more complex testing examples

Open
#23,297 3 comments 1 reaction 1 assignee View on GitHub

Nobody has claimed this yet.

Assessment

This issue has not been assessed yet.

Description

feature feature: insufficient votes feature: votes required freq1: low

📚 Docs or angular.io bug report

Description

There is already a pretty good documentation in regards to Angular CLI Builders, however, I get stuck right after trying something more complex than triggering a simple command.

I am extending the existing @angular-devkit/build-ng-packagr builder, so that certain logic is executed after the packagr builder is done. That all works fine, however I don't know how to test it correctly.

I tried to create a fake workspace, where I would run my builder, but obviously that fails due to absence of dependencies, like @angular/core.

I as well tried to look into official builder itself where I found that bunch of deprecated API is used, therefore did not proceed there.

🔬 Minimal Reproduction

What's the affected URL?**

https://next.angular.io/guide/cli-builder

Reproduction Steps**

This can of course be fixed by creating package.json and installing @angular/core in the fake workspace, but is this the right way?

🔥 Exception or Error

Building Angular Package
Building entry point 'lib'
Compiling TypeScript sources through ngc

BUILD ERROR
Could not resolve module @angular/core
Error: Could not resolve module @angular/core
    at StaticSymbolResolver.getSymbolByModule (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/static_symbol_resolver.ts:521:11)
    at StaticReflector.findDeclaration (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/static_reflector.ts:111:29)
    at StaticReflector.initializeConversionMap (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/static_reflector.ts:367:14)
    at new StaticReflector (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/static_reflector.ts:69:10)
    at Object.createAotCompiler (/Users/osk/Workspaces/experimental/packages/compiler/src/aot/compiler_factory.ts:67:7)
    at AngularCompilerProgram._createCompiler (/Users/osk/Workspaces/packages/compiler-cli/src/transformers/program.ts:651:22)
    at AngularCompilerProgram.get [as hostAdapter] (/Users/osk/Workspaces/packages/compiler-cli/src/transformers/program.ts:531:12)
    at AngularCompilerProgram._createProgramWithBasicStubs (/Users/osk/Workspaces/packages/compiler-cli/src/transformers/program.ts:690:71)
    at /Users/osk/Workspaces/packages/compiler-cli/src/transformers/program.ts:240:17

Dominant language
TypeScript
Stars
27k
Forks
11.8k
Avg merge
16h 35m
Merged PRs (30d)
176

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from angular/angular-cli

All issues in angular/angular-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.