Architect#scheduleBuilder or context.scheduleBuilder results in incorrect target on context

Open
#19,905 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
build-system

Research direction

Start with packages/angular_devkit/architect/src/index_spec.ts and reproduce the failure using yarn bazel test //packages/angular_devkit/architect:architect_test. Trace the builder context through packages/angular_devkit/architect/src/create-builder.ts, where the stack points, and verify that scheduleBuilder provides a target matching its declared TypeScript interface. Done means the focused architect test passes with a valid target.

Written by the indexing model from the issue text.

Description

area: @angular-devkit/architect freq1: low severity3: broken type: bug/fix

🐞 Bug report

Command (mark with an x)
  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc
Is this a regression?

Not that I know of

Description

If a builder is executed via architect.scheduleBuilder, that builder is passed a context that doesn't match the declared interface in typescript. The same happens when using context.scheduleBuilder if no target is passed via the scheduleOptions.

console.log(context.target);
// logs {project: undefined, target: undefined, configuration: undefined}
// but type is {project: string, target: string, configuration?: string} | undefined

🔬 Minimal Reproduction

Run yarn bazel test //packages/angular_devkit/architect:architect_test with the following patch:

diff --git a/packages/angular_devkit/architect/src/index_spec.ts b/packages/angular_devkit/architect/src/index_spec.ts
index 57d76c5a6..bbd59b3fc 100644
--- a/packages/angular_devkit/architect/src/index_spec.ts
+++ b/packages/angular_devkit/architect/src/index_spec.ts
@@ -36,10 +36,12 @@ describe('architect', () => {
 
     options = {};
     called = 0;
-    testArchitectHost.addBuilder('package:test', createBuilder(async o => {
+    testArchitectHost.addBuilder('package:test', createBuilder(async (o, ctx) => {
       called++;
       options = o;
 
+      expect(ctx.target != null && ctx.target.target == null).toBe(false);
+
       return new Promise<BuilderOutput>(resolve => {
         setTimeout(() => resolve({ success: true }), 10);
       });

🔥 Exception or Error


Failures:
1) architect runs builders parallel
  Message:
    Expected true to be false.
  Stack:
    Error: Expected true to be false.
        at 
        at packages/angular_devkit/architect/src/index_spec.ts:43:63
        at onInput (packages/angular_devkit/architect/src/create-builder.ts:201:20)
        at SafeSubscriber._next (packages/angular_devkit/architect/src/create-builder.ts:87:17)

🌍 Your Environment

Master branch on this repo

Anything else relevant?

Dominant language
TypeScript
Stars
27k
Forks
11.8k
Avg merge
16h 35m
Merged PRs (30d)
176

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from angular/angular-cli

All issues in angular/angular-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.