angular-ui/ui-grid

[BUG] Something is not working

Open

#7,311 opened on May 3, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedtype: bug

Description

Describe the bug Column sort pop-up highlight both Sort Ascending and Sort Descending option.

To Reproduce Steps to reproduce the behavior:

  1. Open complex grid example(http://ui-grid.info/ from home page is also fine)
  2. Click on one of columns sort setting icon
  3. Pop-up will appear
  4. Initially ascending is highlighted. Click on descending.
  5. Pop-up will get disappear
  6. Again click on same sort setting icon.
  7. Observe that both option are highlighted

Expected behavior Only descending option should be highlighted.

Screenshots image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome
  • Version: latest

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of AngularFamiliarity with CSS selectorsUnderstanding of DOM event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The bug is likely in the sort popup component of ui grid. Look at files related to column header sorting, probably in the `src/features/sort` directory. The issue is that the highlight state for sort direction is not correctly reset after the popup is reopened. Check the logic that toggles the CSS classes for 'ascending' and 'descending' when the sort icon is clicked. The popup should only highlight the active sort direction. Investigate the `ui grid column menu` or similar directive that handles the sort popup. Also check for any state management that might persist the previous selection incorrectly.