angular-ui/ui-grid

Aria-required-parent and aria-valid-attribute-values are not present

Open

#7,229 opened on Jun 30, 2022

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
a11ygrid-corehelp wanted

Description

Issue: Aria-required-parent and aria-valid-attribute-values are not present

Repro steps:

  1. Open UI Grid: 401 All Features (ui-grid.info) CodePen.
  2. Scroll down to the demo section
  3. Click on the hamburger icon in top right corner table to show the options
  4. Inspect using F12
  5. Observe the controls does not have Aria-required-parent and aria-valid-attribute-values.

Actual Result:

Aria-required-parent and aria-valid-attribute-values are not present

Expected Result:

Aria-required-parent and aria-valid-attribute-values should present

Notes:

Issue is reproducible in all the controls displayed under 'Rows'

Screenshot: image

image

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontendaccessibility
Issue type
accessibility
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of ARIAAngularJS (1.x) directive basicsUI Grid codebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
The issue reports missing ARIA attributes (aria required parent and aria valid attribute values) on controls under 'Rows' in UI Grid. Begin by examining the grid's cell rendering templates in the 'src/templates' directory, particularly for column headers and cell content. Look at how existing ARIA attributes are implemented in similar elements, then add the missing ones. There are no linked PRs or assignees, so the issue is open for contribution.