angular-ui/ui-grid

Cannot enter deepEdit when enableCellEditOnFocus = true with F2

Open

#7,213 opened on Feb 19, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
a11ygrid-edithelp wantedneeds: analysis

Description

Hi, great job on the grid! I have a couple of issues, here is the first one. When enableCellEditOnFocus=true for the Grid you cannot enter deepEdit with the F2 key. Line 14368 of ui-grid.js is:

if (rowCol.row === $scope.row && rowCol.col === $scope.col && !$scope.col.colDef.enableCellEditOnFocus) {

The last condition will not let you enter deepEdit if already in (none deep-) editing mode due to enableCellEditOnFocus=true.

Event with enableCellEditOnFocus=true you sometimes want to enter deepEdit mode in order to be able to change the text by navigating inside the input control with the arrow keys, and not just overwriting the entire text. Grid Navigation will change cell focus with the arrow keys unless in deepEdit.

Thanks!

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptangular knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is in ui grid.js at line 14368 where a condition prevents deep edit mode when enableCellEditOnFocus is true. The fix likely involves modifying that condition to allow F2 to trigger deep edit regardless of enableCellEditOnFocus. Review the grid edit logic and test with a local setup. Consider checking if F2 key event is properly handled.