angular-ui/ui-grid

Expandable grid tutorial is broken

Open

#7,122 opened on Sep 24, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
grid-expandablehelp wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The expandable grid tutorial has render issues when all sub grids are expanded where the rows disappear. It's easy to replicate

  1. Go to http://ui-grid.info/docs/#!/tutorial/Tutorial:%20216%20Expandable%20grid
  2. Scroll down to the first grid demonstration
  3. Click "Toggle Expand All Visibility"
  4. Scroll down the grid a little way, the rows all disappear.

Similar issues reported here. https://github.com/angular-ui/ui-grid/issues/3473 https://github.com/angular-ui/ui-grid/issues/4508

Contributor guide

Research direction
Reproduce the bug in a local environment. Inspect the expandable grid rendering logic, particularly the 'toggle expand all' functionality and row visibility calculations. Check for similar fixes in linked issues #3473 and #4508. Look at the scroll handler that updates row visibility when all subgrids are expanded.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitAngularJSJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60