angular-ui/ui-grid

Disabling sort still allows sorting using keyboard

Open

#7,096 opened on Jul 12, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
grid-corehelp wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Please make sure each of the following is true before submitting a new issue. We are a small team with limited time and it is very difficult to manage issues if they aren't reported correctly.

  • This is a bug report, not a question on how to use the grid.
    Use Stack Overflow or Gitter for questions.
  • You have searched the open issues to see if this bug has been filed before. We don't want duplicate issues.
  • You have reviewed the tutorials and documentation to ensure you are using the grid correctly. ui-grid.info
  • You are using the latest version of the grid. Older versions are not patched or supported.
  • You have provided steps to recreate your bug. A plunkr is even better.

Providing EnableSorting=false in gridOptions disables sorting using mouse and removes sorting options from the column header dropdown. However, it still allows sorting using keyboard(using space bar).

Plunkr link: http://plnkr.co/edit/B6x68zlUPLKAPpmo

Contributor guide

Research direction
Inspect the keyboard event handler that triggers sorting via spacebar and ensure it respects the enableSorting flag.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70