angular-ui/ui-grid

Expandable with enableFullRowSelection

Open

#7,089 opened on Jun 22, 2020

View on GitHub
 (2 comments) (0 reactions) (1 assignee)JavaScript (2,496 forks)batch import
good first issuegrid-selection

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When enableFullRowSelection is also used, the click event on the expand button also triggers the selection.

Ideally this would caught in the toggleRowExpansion function, but for those in immediate need, at the end of me on.rowExpandedStateSelection you can add something like:

              if (event !== undefined && event.currentTarget !== undefined && event.currentTarget.tagName === "I")
              {

// Cancel bubble of event }

This way the full row selection isn't executed.

Contributor guide

Research direction
Investigate the `on.rowExpandedStateSelection` function and prevent event propagation when the click target is the expand icon (e.g., an `<i>` element).
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75