angular-ui/ui-grid

focus jumps to random row after pressing enter while using cellNav with edit enabled

Open

#6,978 opened on May 14, 2019

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (2,496 forks)batch import
grid-cellNavhelp wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, in grid with edit and cellNav enabled randomly happens, that after pressing enter key in cell, the focus doesn't jump to next row, but instead it skips few rows and sometimes it goes all the way to top. It happens in longer grids after some scrolling.

Video of the issue: https://imgur.com/ntnCdPv Plunker: http://plnkr.co/edit/Q8CW68OWovbt7NDFbAJs?p=preview

Thanks for any help.

Contributor guide

Research direction
Investigate the cell navigation logic in ui grid, specifically the enter key handler, to determine why the focus jumps to incorrect rows after scrolling. Check for off by one errors or viewport calculation issues.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Angular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50