angular-ui/ui-grid

[Performance Increase] Precompile and cache compiled filter templates

Open

#6,973 opened on May 9, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
grid-corehelp wantedseverity: performance

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

instead of $compiling as dom nodes are created the templates (especially built in ones) should be compiled before hand that way it saves on processing and increases performance.

When the user adds their own template in place of a built in one, it should immediately compile and cache the compiled template by using the src directory as the key to map the compiled template.

This should increase the performance of the grid slightly.

---EDIT--- after further looking at the code i can see that precompiled templates are a thing in most of the application. However the reason i initially posted this was because filters are not being pre-compiled

Contributor guide

Research direction
Investigate how built in filter templates are currently compiled and loaded. Look for opportunities to precompile them and cache them by src directory.
Tech stack
javascriptangular
Domain
frontend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptAngularui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45