angular-ui/ui-grid

[Performance Increase] Replace prototype forEach/map within ui-grid for better performance

Open

#6,960 opened on Apr 19, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issuegrid-coreseverity: performance

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

http://jsben.ch/N3AVA

Looking at the performance of the faster ForEach/map functions written you can see that significant performance increase happens over the built in forEach/map prototype on a javascript array.

I saw that ui-grid uses the built in prototypes and figured they could use a performance increase so that ui-grid becomes more responsive with larger grid sizes. The larger the array, the more significant of a performance increase it has!

Contributor guide

Research direction
Identify all usages of `forEach` and `map` on arrays in the `ui grid` source code, benchmark the performance using tools like jsben.ch, and replace them with faster alternatives like `for` loops or optimized functions. Ensure no breaking changes.
Tech stack
javascriptangular
Domain
frontend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65