angular-ui/ui-grid

Rows remain expanded when doing clearFilter and collapse at once

Open

#6,941 opened on Feb 26, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
grid-expandablehelp wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When in an expandable grid with all rows expanded, you filter for something and then programmatically clear all filters and collapse all rows (gridApi.expandable.collapseAllRows() and gridApi.grid.clearAllFilters()) at once, you get an unexpected behavior: Only the row(s) previously filtered gets collapsed while all the others remain expanded.

See Plunker: http://next.plnkr.co/edit/sB71ZwrmqVt9BUU5?preview

My issue might be related to: https://github.com/angular-ui/ui-grid/issues/4044 but I'm not sure if it's 100% the same.

Contributor guide

Research direction
Investigate the interaction between clearAllFilters() and collapseAllRows() in the expandable grid. Trace the event handling order and check if filter clearing triggers an expand event that interferes with collapse.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75