angular-ui/ui-grid

getScrollbarWidth fails in Firefox under certain conditions

Open

#6,937 opened on Feb 20, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issuegrid-core

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have an app where body height is 100vh and children fill the whole height, in this case "outer" element created by getScrollbarWidth is out of browser view port and it seems Firefox doesn't draw any scrollbars in it so inner and outer widths are the same. I'm able to fix it by adding position absolute to the outer style: outer.style.position = 'absolute'; Could somebody publish the fix to the npm, please? Or should I make a pull request?

Contributor guide

Research direction
Add 'position: absolute' to the outer element's style in the getScrollbarWidth function to ensure scrollbars are rendered in Firefox.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90