angular-ui/ui-grid

Grid height not getting adjusted

Closed

#6,916 opened on Jan 11, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (PR metrics pending)

Description

I have a filter row and ui-grid. when the filter is toggled (visible), the ui-grid's height is not getting resized and so last few rows and vertical scroll bar is getting hidden below.

I tried to set the height as auto instead of setting in %, but then it takes only half of the available space always. Also, I have tried the autoResize feature of ui-grid.

<div>
 <div class="row" id="toggleFilter"></div> 
 <div class="grid"></div>
</div>

Contributor guide

Research direction
Investigate the grid height calculation in ui grid, especially when filter row visibility changes. Look for CSS or JavaScript logic that sets the grid height and ensure it recalculates on toggle.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70