angular-ui/ui-grid

paginationApi.getLastRowIndex and grid.options.totalItems wrong when filtered and data externally changed

Open

#6,897 opened on Nov 27, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I am using paginationApi.getLastRowIndex() and grid.options.totalItems inside a custom pagination template, done via $templateCache.put('ui-grid/pagination',.

That works in general. However, the results are wrong if two conditions happen:

  • A column filter is active
  • While the column filter is active, the data is externally changed, rendering the filter condition false for at least one row.

The actual result displayed is, in this case, the "maximum" (unfiltered) number of items - as if the filter was not there.

I have created a Plunker: http://next.plnkr.co/edit/i32TV4PrYIJby8Uy?preview

Steps for reproducing error there:

  • Filter for City: "Tokio"

  • Click on "Transfer Maria from Tokio to Paris"

  • Pagination footer wrong

Contributor guide

Research direction
Inspect the Plunker example and trace how pagination counts are recalculated when external data changes while a filter is active. Look at the grid internals for pagination (e.g., getLastRowIndex and totalItems) to see if they properly re evaluate filtered data.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJSui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75