angular-ui/ui-grid

Basic Issue: enableCellEditOnFocus only works every other time, even in Tutorial

Open

#6,893 opened on Nov 19, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wantedneeds: analysis

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When using enableCellEditOnFocus, it only works every other click.

Here is a modified Plunkr of Tutorial: 201 Edit Feature: http://plnkr.co/edit/KkrTaTQJGtgQGsc6WrB3?p=preview

Click on a cell in the Name column: you can edit it. Click on another cell in the Name column: it just selects the cell, does not bring up an editor. Repeat.

This problem was introduced in v4.0.8. It's quite a severe problem, apparently rendering enableCellEditOnFocus somewhat unusable. I hope this can be fixed: otherwise I can't take any of the many improvements since then.

Contributor guide

Research direction
Reproduce the bug using the provided Plunkr and trace the cell edit focus logic to find the condition causing the alternating behavior.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70