angular-ui/ui-grid

selection api is broken when no $$hashKey is used on rows

Open

#6,860 opened on Oct 1, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (2,496 forks)batch import
grid-selectionhelp wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

this issue is caused by https://github.com/angular-ui/ui-grid/commit/0e832250ca0c5899558f1e07b9f3736b667f53ce , $$hashKey is not a mandatory field, we use custom rowEquality and rowIdentity so getSelectedRows API will always return empty array

Contributor guide

Research direction
Inspect the commit 0e832250ca0c5899558f1e07b9f3736b667f53ce to see how $$hashKey removal broke selection. Focus on rowEquality and rowIdentity custom functions.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65