angular-ui/ui-grid

emptyBaseLayer.directive and expandable.directive collision

Open

#6,830 opened on Aug 8, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issuegrid-empty-base-layer

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Because of the same priority with emptyBaseLayer.directive, expandable.directive on line: var rowRepeatDiv = angular.element($elm.children().children()[0]);

Gets the rowRepeatDiv of wrong element: div.ui-grid-empty-base-layer-container.ui-grid-canvas instead of: div.ui-grid-canvas (which is the second element of the array - $elm.children().children()[1])

Becouse of that, sub-rows wont get rendered. Raising expandable.directive priority fixes the rendering.

Is it a good case for a pullrequest? Or is it because of my configuration? I also use:

  • ui-grid-pagination
  • ui-grid-auto-resize
  • ui-grid-selection

I tried ui-grid-empty-base-layer="false", but that didn't help.

Contributor guide

Research direction
Inspect the priority values of emptyBaseLayer.directive and expandable.directive in the source code, then adjust expandable.directive priority to be higher than emptyBaseLayer.directive. Verify the fix by running tests related to expandable functionality.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75