angular-ui/ui-grid

Grid Column Resizer leaves margin at the right end of last header column

Open

#6,824 opened on Aug 4, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Enabling ui-grid-resize-columns leaves a margin at the right side of last header column on v4.6.2, which wasnt the issue in v4.0.0

Margin gets hidden below the ui-grid-menu-button, but in my case height of the header gets changed due to additional filters

imageedit_1_5538927245

for now i have overwritten the class present in ui-grid.css file to minimise the margin width

.ui-grid-header-cell-last-col + .ui-grid-column-resizer.right {
    margin-right: 0px !important;
 }

imageedit_3_3171336784

is there any reason for increasing margin right value at the last header column ,if so is there any other way to fix this like setting up ui-grid-menu-button height dynamically according to the the ui-grid-header height

Contributor guide

Research direction
Inspect the CSS rule `.ui grid header cell last col + .ui grid column resizer.right` in ui grid.css and trace the change from v4.0.0 to v4.6.2 using git blame.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70