angular-ui/ui-grid

ui-grid.ttf is not a valid font file

Open

#6,809 opened on Jul 25, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In 4.6.2, when double clicking on src/font/ui-grid.ttf in Windows, it shows a dialog that indicates "The requested file ...\ui-grid.ttf is not a valid font file".

Looking at a diff of the file between commit 8096ed043b and ec13255f61, it looks like a "0D 0A" was changed to just a "0A", so it appears that a CRLF to LF conversion was done.

The ui-grid.eot file seems to also have gone through a CRLF to LF conversion.

Contributor guide

Research direction
Inspect the binary font files to ensure they are stored with correct line endings in Git. Add or update .gitattributes to treat .ttf and .eot files as binary.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75