angular-ui/ui-grid

Edited cell will always refocus when scrolling grid

Open

#6,794 opened on Jul 5, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
grid-edithelp wantedwaiting-response

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I am using version 4.4.4 and things messed up with the scrolling. The edited cell will always refocus when scrolling grid horizontally. I tried to fix the issue by commenting "uiGridCtrl.cellNav.broadcastCellNav(lastRowCol);" but it lead to tab/edit issue. Please let us know if we have any fix for the same.

grid.api.core.on.scrollEnd($scope, function (args) { // Skip if there's no currently-focused cell var lastRowCol = uiGridCtrl.grid.api.cellNav.getFocusedCell(); if (lastRowCol === null) { return; }

            //if not in my container, move on
            //todo: worry about horiz scroll
            if (!renderContainerCtrl.colContainer.containsColumn(lastRowCol.col)) {
              return;
            }

          //uiGridCtrl.cellNav.broadcastCellNav(lastRowCol); // -- Commented this line**
          });

Contributor guide

Research direction
Investigate the scrollEnd event handler in the grid, focusing on the broadcastCellNav call that causes the refocus. Examine the cellNav module to understand how broadcastCellNav affects focus and scrolling behavior, and consider alternatives that prevent refocus while preserving edit functionality.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
AngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45