angular-ui/ui-grid

cell navigation/edit on focus breaks custom template

Open

#6,783 opened on Jun 28, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
grid-cellNavgrid-edithelp wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I am using a custom dataList template I created which I am referencing in this issue: https://github.com/angular-ui/ui-grid/issues/6755

However I found another issue. When I turn on cell navigation and edit on focus, it no longer functions properly. The drop down works initially, but you cannot type anything into the cell. Also if you click on it once something is selected, you cannot change or delete the contents. This is obviously a problem because the dataList should be able to be edited and changed. Functionality works when I remove edit on focus and cell navigation but the initial problem I talked about in issue 6755 is still there.

Contributor guide

Research direction
Examine the custom dataList template and how it interacts with cell navigation and edit on focus features. Check the ui grid issue #6755 for context and look at the relevant source code for cell editing.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Angularui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55