angular-ui/ui-grid

100% width with grids and tabs

Open

#6,777 opened on Jun 27, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is a bit tricky to replicate, but I'll update the issue with a plunkr if I manage to get it.

I have 3 tabs (bootstrap library - uib-tab) with a grid in each and css with width: 100%. The horizontal scrolling sometimes is out of sync (i.e. header doesn't scroll but rows do) and seems quite similar to #2592. I don't think it's the same because when I look at the DOM in Chrome Dev Tools, I notice that the "broken" grid has .ui-grid-viewport { width: 100%0px; ... } which obviously doesn't work and seems to be the issue.

I'm not entirely sure why this happens. It seems like a bit of a race condition. I'm calling gridApi.core.refresh() and gridApi.core.handleWindowResize() on tab change, but it's not helping.

Contributor guide

Research direction
Investigate the race condition causing .ui grid viewport width to be set incorrectly (e.g., '100%0px') when switching tabs. Check the grid initialization sequence and the timing of resize events. Consider using gridApi.core.handleWindowResize() after the tab content is fully rendered. Look at related issue #2592 for similar problems.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
AngularCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25