angular-ui/ui-grid
View on GitHubenableCellEditOnFocus does not work properly when a lot of columns.
Open
#6,772 opened on Jun 21, 2018
good first issuegrid-editneeds: analysis
Repository metrics
- Stars
- (5,395 stars)
- PR merge metrics
- (No merged PRs in 30d)
Description
http://plnkr.co/edit/vpms1zqjILXS1QoeCYlm?p=preview To reproduce the problem you should сlick on the first cell, and then press the right arrow key until you force the table to initiate the scroll action. The cell outside the visible part of the table will not be active for editing. I think that the problem is in the last line of the ScrollHandler function.
function scrollHandler(evt) {
var newScrollTop = $elm[0].scrollTop;
var newScrollLeft = gridUtil.normalizeScrollLeft($elm, grid);
var vertScrollPercentage = rowContainer.scrollVertical(newScrollTop);
var horizScrollPercentage = colContainer.scrollHorizontal(newScrollLeft);
var scrollEvent = new ScrollEvent(grid, rowContainer, colContainer, ScrollEvent.Sources.ViewPortScroll);
scrollEvent.newScrollLeft = newScrollLeft;
scrollEvent.newScrollTop = newScrollTop;
if ( horizScrollPercentage > -1 ){
scrollEvent.x = { percentage: horizScrollPercentage };
}
if ( vertScrollPercentage > -1 ){
scrollEvent.y = { percentage: vertScrollPercentage };
}
grid.scrollContainers($scope.$parent.containerId, scrollEvent);
}