angular-ui/ui-grid

when using editDropdownRowEntityOptionsArrayPath you MUST declare the editableCellTemplate prior to editDropdownLabel or you get undefined in the dropdown for the options

Open

#6,743 opened on Jun 8, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedneeds: analysis

Description

Normally when using a dropdown, it doesn't matter what order you put the items in the column definition object. I don't know if it is a bug or not, but it should at least be documented that if you do not go in this order when using editDropdownRowEntityOptionsArrayPath:

editableCellTemplate: 'ui-grid/dropdownEditor', editDropdownValueLabel: 'rout', editDropdownRowEntityOptionsArrayPath: 'routingNumber'}

you will get all undefined options in your select dropdown(although as soon as you select an option and exit it will display the correct one).

I spent about 6 hours trying to figure out why this was happening because I initially had it declared as this:

editDropdownValueLabel: 'rout', editableCellTemplate: 'ui-grid/dropdownEditor', editDropdownRowEntityOptionsArrayPath: 'routingNumber'}

which works perfectly fine when declaring a normal array in the editDropdownOptionsArray.

Please either fix this so order doesn't matter or at least put documentation that this is the case so other people are not spending numerous hours chasing down a bug that is a little crazy.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSui grid basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the order dependency of properties in the column definition when using editDropdownRowEntityOptionsArrayPath. The issue specifically mentions that editableCellTemplate must be declared before editDropdownValueLabel and editDropdownRowEntityOptionsArrayPath. Look into the dropdown editor initialization code in ui grid (likely in templates or core grid logic) to see if there is a bug or if the order can be made irrelevant. Also consider updating the documentation to note the required order. The issue is from 2018 and has no activity, so verify the current state of the codebase.