angular-ui/ui-grid

expanded/collapsed state not restored on saveState.restore

Open

#6,718 opened on May 4, 2018

View on GitHub
 (3 comments) (2 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

I traced the code in grouping.js and found the issue at line 808 when the applyRowExpandedStates is called, the first argument "grid.grouping.groupingHeaderCache" is an empty object.

My theory is that the grouping that was just applied a few lines above didn't apply yet and therefore the groupingHeaderCache was not yet set.

To prove my theory, i added a setTimeout to line 808 as follows:

if ( config.rowExpandedStates ){
          setTimeout(function(){service.applyRowExpandedStates( grid.grouping.groupingHeaderCache, config.rowExpandedStates )});
        }

and that made it work.

Can you guys look into this and provide a fix if this is indeed a bug? and I think it is because even on your tutorial page http://ui-grid.info/docs/#!/tutorial/208_save_state, the state of expanded rows is not restored. To reproduce it there, you need to group on a column, expand one and Save. Then ungroup and restore. .

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Angularui grid knowledgeunderstanding of async rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue is in grouping.js at line 808 where applyRowExpandedStates is called with an empty groupingHeaderCache. Investigate why the cache is empty at that point; a workaround using setTimeout suggests an async timing issue. Check the save/restore flow to ensure grouping is fully applied before restoring expanded states. Look for existing comments or PRs related to this bug.