angular-ui/ui-grid

Multi custom filter save state

Open

#6,585 opened on Mar 2, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

When using UI-grid custom filters (either the tutorial one or the ui-grid-multiselect-filter on npm ), the filters are stored in a listTerm object and in the default term object (Separated by commas).

The default grid restore tries to restore the term object which breaks the filter. If I log the state in the console I can see a filters array for each column containing 2 objects a "listTerm" array containing the selected terms and a term object containing the same values separated by commas as term :"filvalue1, filvalue2," I think grid is restoring this comma separated object and treating it as a single filter text. any ideas how to get it recognize the comma as a separator or to do this in a different way?

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
Familiarity with AngularJSBasic understanding of UI Grid filters
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Examine the filter save/restore implementation in UI Grid source code, particularly files related to grid saving and filter handling such as 'gridSaveState' and filter serialization. Look at how `listTerm` and `term` objects are used in the custom filter and restore process. Also review the `ui grid multiselect filter` package if relevant. No linked PR, so investigate whether the issue has been addressed in later versions.