angular-ui/ui-grid

selectAllVisibleRows() should be selecting only the current page rows

Open

#6,479 opened on Nov 26, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

In the case of client side paginated data, selectAll button action should be selecting only current page rows. Also when pages are navigated, the selectAll button should be deselected.

Is this a bug or an intended feature? In selectAllVisibleRows, shouldnt grid.getVisibleRows() be iterated instead of grid.rows?

Contributor guide

Tech stack
angularjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Angular basicsui grid APIpagination concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Review the `selectAllVisibleRows` implementation in the ui grid source code (likely in `src/features/selection/`). Compare usage of `grid.rows` vs `grid.getVisibleRows()` and confirm that the pagination logic distinguishes visible rows. Test the fix with client side pagination enabled to ensure only current page rows are selected. Also verify that the selectAll button state resets on page change.