angular-ui/ui-grid

When cell is filtering enable and date is formatted the search is incorrect

Open

#6,379 opened on Aug 28, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Hey guys,

BTW, keep up the blaster work!

I'm using UI-GRID in a nice table with townsend values. This grid has a date column with a custom format dd/MM/yyyy (the original value is a longdate in USA standard format)

When you'll search in this column using a custom format (i.e 25/08/2017) UI-GRID has no rows to display. But, when try using a longdate format, the filter works fine.

I think this is an issue.

Besides, there's any temporary solution to this?

Tks in advance!

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of AngularJSUnderstanding of ui grid filtering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate how ui grid's filtering logic handles custom date formats. Look at the grid's column filtering code, possibly in the 'src/features/filter' directory. Check the date formatter used and how the filter comparison works. Consider if the issue is due to string comparison vs date object comparison.