angular-ui/ui-grid

save() works but restoreState($scope, $scope.state) doesn't

Open

#6,355 opened on Aug 10, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Both these functions live in $scope.gridApi.saveState. One works, the other returns one of two errors (gridApi is undefined or cannot find property saveState of undefined) at first I was looking into this issue as a $scope.gridApi problem, but then I realized it makes no sense that save works and restore is throwing the error it is throwing.

Contributor guide

Research direction
Compare the implementations of save() and restoreState() in the saveState service, focusing on how they access $scope.gridApi. Look for asynchronous timing or initialization issues that cause gridApi to be undefined when restoreState is called.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65