angular-ui/ui-grid

save() works but restoreState($scope, $scope.state) doesn't

Open

#6,355 opened on Aug 10, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

Both these functions live in $scope.gridApi.saveState. One works, the other returns one of two errors (gridApi is undefined or cannot find property saveState of undefined) at first I was looking into this issue as a $scope.gridApi problem, but then I realized it makes no sense that save works and restore is throwing the error it is throwing.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS basicsui grid knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the `saveState` service in ui grid, specifically the `restoreState` method. Compare its implementation with the working `save` method. Check for differences in how `gridApi` is accessed or initialized. The error suggests `gridApi` is undefined in the context of `restoreState`, so look at the scope chain and how the grid API is exposed. Review the source code at https://github.com/angular ui/ui grid/tree/master/src/features/save state to identify the issue.