angular-ui/ui-grid

SyntaxError: Invalid regular expression: /^/[\s\S]*?+$/: Nothing to repeat when entering the filter term "*+" or "*(" etc

Open

#6,335 opened on Jul 25, 2017

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I m using the latest version v4.0.6, before this I was using v4.0.4, I get the following stacktrace after entering "+", "(", "*)" as the filter expression.

SyntaxError: Invalid regular expression: /^[\s\S]*?+$/: Nothing to repeat
at RegExp (<anonymous>)
at Object.guessCondition (ui-grid.js:9731)
at Object.setupFilters (ui-grid.js:9782)
at Object.search (ui-grid.js:9997)
at Grid.searchRows (ui-grid.js:5579)
at startProcessor (ui-grid.js:5073)
at handleProcessedRows (ui-grid.js:5089)
at angular.js:15757
at m.$eval (angular.js:17025)
at m.$digest (angular.js:16841)

I have used to sort out this by "condition: uiGridConstants.filter.CONTAINS", it works on grids having server side filtering while its not working for other grids

Contributor guide

Research direction
Examine the regular expression generation in guessCondition and ensure special characters like * and + are escaped properly before constructing the regex.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75