angular-ui/ui-grid

NVDA says 'grouping' when go from grid header to grid itself, but no grouping applied

Open

#6,327 opened on Jul 20, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
a11yhelp wanted

Description

NVDA says 'grouping' when go from grid header to grid itself, but no grouping is applied. If proceed navigation to another cell, NVDA doesn't repeat 'grouping' anymore. If any cell is selected and during navigation focus goes not to first cell, but to selected one, issue is also reproduced.

STEPS TO REPRODUCE:

  1. Turn on NVDA.
  2. Go to page with grid, e.g. http://ui-grid.info/docs/#/tutorial/122_accessibility.
  3. Move focus till last field in the filter row.
  4. Press TAB. -> Focus goes to the whole table and NVDA reads out 'table editable grouping'.
  5. Press TAB. -> Focus goes to the first cell in the grid and NVDA reads out 'Ethel Price grouping'. Expected result: NVDA doesn't read out 'grouping' as it's not applied and can confuse accessible user. In it should be consistent - if grouping applied, but NVDA reads out it only for first cell, so no 'grouping' should be read out after navigation from the grid header to cell in the grid.

I am adding attachments with reproducing. There I:

  1. set focus to input field in gender column.
  2. pressed TAB -> NVDA reads out 'grouping' for whole grid.
  3. pressed TAB -> NVDA reads out 'grouping' for first cell.
  4. pressed TAB -> NVDA doesn't read out 'grouping' for second cell.

In the bug description I mainly focused on the reading out 'grouping' for the first cell as exactly this issue affects our application, but reading 'grouping' for whole grid also doesn't look like expected, so please, pay attention on this as well.

NVDA Grid Grouping.zip

Contributor guide

Tech stack
javascriptangular
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Accessibility basicsARIA attributesAngularJSNVDA testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Focus on the grid's accessibility code, likely in the GridAccessibility module. Locate where the 'grouping' string is set as an ARIA attribute for the grid and its cells. Determine why it is announced even when no grouping is active. The fix should ensure the 'grouping' announcement only occurs when grouping is actually applied. Test with NVDA to verify the behavior. No existing PRs or comments, so start from scratch.