angular-ui/ui-grid

Scrolling editable rows with down arrow triggers change event with wrong cell values

Open

#6,298 opened on Jul 6, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

The example below is originally from the tutorials. Browser is Chrome.

  1. plunkr
  2. select any name
  3. Edit mode is on
  4. now press and hold the down arrow until the grid starts scrolling.
  5. you will now see the details of the last cell changed in the 'last cell edited' field. Although i have not changed anything.

The change should trigger only when the old/new values of the cell has changed. I am simply skipping the 'afterCellEdit' event when the new/old values are the same.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Angular.jsFamiliarity with ui grid event model
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the afterCellEdit event handler in ui grid to ensure changes are only triggered when cell values actually change. The reporter suggests skipping the event when old and new values are identical. The issue includes a plunkr example (http://plnkr.co/edit/WizlYTzwdif3Exp1pTDT?p=preview) to reproduce the bug. Look at the grid's cell edit functionality and the event propagation to implement the fix.
Scrolling editable rows with down arrow triggers change event with wrong cell values · angular-ui/ui-grid#6298 | Good First Issue