angular-ui/ui-grid

Question about grid.getVisibleRows()

Open

#6,294 opened on Jul 4, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

According to the angular-ui-grid@4.0.6

Here is the code: (about line 5560)

Grid.prototype.getVisibleRows = function getVisibleRows() {
    return this.renderContainers.body.visibleRowCache;
};

Why visible rows from the visibleRowCache? Because the visibleRowCache just have the current page data. Therefore, we need to get visible rows by using row.visible, rather than grid.getVisibleRows. But i don't know whether it is a bug?

Will you pretty good guys to fix this problem? :)

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJSui grid internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue questions the behavior of grid.getVisibleRows() in angular ui grid. Line 5560 returns this.renderContainers.body.visibleRowCache, but the user suggests it should use row.visible. No maintainer response or PRs exist. Investigate the current implementation in the repository's source code (e.g., Grid.js) to determine if visibleRowCache correctly represents visible rows, considering pagination, and verify if the issue persists in recent versions. The goal is to confirm if this is a bug and propose a fix if needed.